Conversation
bdist_dir
timkpaine
approved these changes
Jun 18, 2021
Member
timkpaine
left a comment
timkpaine
left a comment
There was a problem hiding this comment.
im +1 so long as we check the scheduled builds for wheel problems
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a wheel build for Windows (tested locally to make sure it installed), and limits wheel generation on Azure Pipelines to tagged and scheduled builds only. This is especially important on Windows builds as the wheel build adds another 15-20 minutes to the entire build. Additionally, the PR also removes the MacOS Python 3.7 build from the general rotation, and limits our per-commit builds to the following: